Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): upgrade to react 18.3.1 #6505

Merged
merged 1 commit into from
Apr 29, 2024
Merged

chore(deps): upgrade to react 18.3.1 #6505

merged 1 commit into from
Apr 29, 2024

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented Apr 26, 2024

Description

Upgrades to use React 18.3(.1) in our dev and example studios.

This should help us reveal any use of APIs that are deprecated/will change in React 19.

@rexxars rexxars requested review from a team as code owners April 26, 2024 23:09
@rexxars rexxars requested review from pedrobonamin and jtpetty and removed request for a team April 26, 2024 23:09
@vercel Vercel
Copy link

vercel bot commented Apr 26, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Apr 29, 2024 5:48pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 5:48pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 5:48pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Apr 29, 2024 5:48pm

@rexxars rexxars requested review from bjoerge and removed request for jtpetty April 26, 2024 23:09
@socket-security Socket Security
Copy link

socket-security bot commented Apr 26, 2024 •
edited

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@jest/expect@29.7.0 None 0 5.23 kB simenb
npm/@jest/globals@29.7.0 Transitive: eval +10 666 kB simenb
npm/@juggle/resize-observer@3.4.0 None 0 73.7 kB trem
npm/@lezer/highlight@1.2.0 None +1 336 kB marijn
npm/@node-ipc/compat@9.2.5 filesystem, network +1 140 kB aarondewes
npm/@playwright/experimental-ct-react@1.41.2 Transitive: environment +1 76 kB yurys
npm/@playwright/test@1.41.2 None 0 25.3 kB yurys
npm/@portabletext/react@3.0.18 None +1 170 kB sanity-io
npm/@portabletext/toolkit@2.0.15 None +1 169 kB sanity-io
npm/@react-three/cannon@6.6.0 None +1 4.22 MB isaacmason
npm/@react-three/drei@9.105.4 network Transitive: environment +11 27.4 MB gsimone
npm/@react-three/fiber@8.16.1 environment +4 769 kB codyjasonbennett
npm/@rexxars/gitconfiglocal@3.0.1 environment, filesystem 0 4.52 kB rexxars
npm/@rexxars/react-json-inspector@8.0.1 None 0 25.5 kB rexxars
npm/@rexxars/react-split-pane@0.1.93 None 0 56 kB rexxars
npm/@rollup/plugin-node-resolve@15.2.3 filesystem +3 200 kB shellscape
npm/@sanity/asset-utils@1.3.0 environment 0 363 kB rexxars
npm/@sanity/assist@3.0.3 network +2 4.69 MB sanity-io
npm/@sanity/bifur-client@0.3.1 None 0 59.7 kB bjoerge
npm/@sanity/client@6.15.20 None 0 2.13 MB sanity-io
npm/@sanity/color@3.0.6 None 0 171 kB sanity-io
npm/@sanity/diff-match-patch@3.1.1 None 0 533 kB sanity-io
npm/@sanity/eslint-config-i18n@1.0.0 None +2 280 kB ricokahler
npm/@sanity/eslint-config-studio@4.0.0 Transitive: unsafe +3 394 kB sanity-io
npm/@sanity/eventsource@5.0.2 None +2 20.3 kB sanity-io
npm/@sanity/export@3.37.4 filesystem +2 606 kB ricokahler
npm/@sanity/generate-help-url@3.0.0 None 0 5.25 kB rexxars
npm/@sanity/google-maps-input@4.0.1 None +2 2.9 MB sanity-io
npm/@sanity/icons@2.11.8 None 0 1.27 MB sanity-io
npm/@sanity/image-url@1.0.2 None 0 166 kB rexxars
npm/@sanity/import@3.37.3 filesystem, network +1 922 kB rexxars
npm/@sanity/locale-ko-kr@1.1.4 None 0 1.03 MB sanity-io
npm/@sanity/locale-nb-no@1.1.7 None 0 950 kB sanity-io
npm/@sanity/locale-nn-no@1.1.6 None 0 951 kB sanity-io
npm/@sanity/locale-pt-pt@1.1.3 None 0 972 kB sanity-io
npm/@sanity/locale-sv-se@1.2.4 None 0 957 kB sanity-io
npm/@sanity/logos@2.1.11 None 0 62 kB sanity-io
npm/@sanity/presentation@1.11.4 None +1 1.16 MB sanity-io
npm/@sanity/presentation@1.12.10 None +1 1.17 MB sanity-io
npm/@sanity/prettier-config@1.0.2 None 0 8.4 kB sanity-io
npm/@sanity/preview-url-secret@1.6.11 None 0 115 kB sanity-io
npm/@sanity/react-loader@1.9.15 Transitive: environment +1 1.35 MB sanity-io
npm/@sanity/telemetry@0.7.7 None 0 116 kB bjoerge
npm/@sanity/test@0.0.1-alpha.1 environment 0 73 kB sanity-io
npm/@sanity/tsdoc@1.0.40 filesystem Transitive: environment, eval, shell, unsafe +55 20.7 MB sanity-io
npm/@sanity/ui-workshop@1.2.11 environment +1 3.53 MB sanity-io
npm/@sanity/ui@2.1.4 None +4 4.94 MB sanity-io
npm/@sanity/uuid@3.0.2 None +1 10.1 kB rexxars
npm/@sanity/visual-editing@1.8.16 environment 0 4 MB sanity-io
npm/@tanstack/react-virtual@3.0.0-beta.54 Transitive: environment +1 600 kB tannerlinsley
npm/@testing-library/jest-dom@6.4.2 None +3 900 kB testing-library-bot
npm/@testing-library/react@13.4.0 environment +6 7.44 MB testing-library-bot
npm/@testing-library/user-event@13.5.0 Transitive: environment +6 3.1 MB testing-library-bot
npm/@turf/helpers@6.5.0 None 0 93.6 kB rowanwins
npm/@turf/points-within-polygon@5.1.5 None +4 372 kB deniscarriere
npm/@types/archiver@6.0.2 None +1 15.1 kB types
npm/@types/arrify@1.0.4 None 0 5.13 kB types
npm/@types/arrify@2.0.1 None 0 1.72 kB types
npm/@types/babel__core@7.20.5 None +1 39.4 kB types
npm/@types/babel__generator@7.6.8 None 0 11.4 kB types
npm/@types/babel__register@7.17.3 None 0 3.88 kB types
npm/@types/babel__traverse@7.20.5 None 0 84.1 kB types
npm/@types/configstore@5.0.1 None 0 6 kB types
npm/@types/connect-history-api-fallback@1.5.4 None +5 76.4 kB types
npm/@types/cpx@1.5.5 None 0 5.66 kB types
npm/@types/debug@4.1.12 None +1 9.65 kB types
npm/@types/decompress@4.2.7 None 0 4.81 kB types
npm/@types/express-ws@3.0.4 None +5 77 kB types
npm/@types/express@4.17.21 None +9 107 kB types
npm/@types/glob@7.2.0 None +1 19.1 kB types
npm/@types/inquirer@6.5.0 None +1 73.4 kB types
npm/@types/jsdom@20.0.1 None +1 35.8 kB types
npm/@types/lodash@4.17.0 None 0 862 kB types
npm/@types/log-symbols@2.0.0 None 0 2.7 kB types
npm/@types/minimist@1.2.5 None 0 6.27 kB types
npm/@types/moment@2.13.0 None 0 508 B types
npm/@types/node-ipc@9.2.3 None 0 20.6 kB types
npm/@types/node@18.19.31 None 0 1.97 MB types
npm/@types/object-inspect@1.13.0 None 0 6.05 kB types
npm/@types/raf@3.4.3 None 0 2.85 kB types
npm/@types/react-copy-to-clipboard@5.0.7 None 0 4.36 kB types
npm/@types/react-dom@18.3.0 None 0 37.8 kB types
npm/@types/react-is@18.3.0 None 0 5.72 kB types
npm/@types/react@18.3.0 None +1 443 kB types
npm/@types/react@18.3.1 None +1 444 kB types
npm/@types/refractor@3.4.1 None +1 47 kB types
npm/@types/resolve-from@4.0.0 None 0 3.04 kB types
npm/@types/rimraf@3.0.2 None 0 7.5 kB types
npm/@types/semver-compare@1.0.3 None 0 2.97 kB types
npm/@types/semver@6.2.7 None 0 13.5 kB types
npm/@types/semver@7.5.8 None 0 23.3 kB types
npm/@types/shallow-equals@1.0.3 None 0 2.86 kB types
npm/@types/speakingurl@13.0.6 None 0 3.96 kB types
npm/@types/tar-fs@2.0.4 None 0 5.96 kB types
npm/@types/tar-stream@3.1.3 None 0 7.85 kB types
npm/@types/tar@6.1.12 None 0 30.2 kB types
npm/@types/three@0.150.2 None +2 926 kB types
npm/@types/use-sync-external-store@0.0.6 None 0 3.29 kB types
npm/@types/validate-npm-package-name@3.0.3 None 0 5.2 kB types
npm/@types/which@2.0.2 None 0 6.06 kB types
npm/@types/ws@8.5.10 None 0 21.7 kB types
npm/@types/yargs@17.0.32 None +1 68.8 kB types
npm/@typescript-eslint/eslint-plugin@7.6.0 None +9 5.32 MB jameshenry
npm/@typescript-eslint/parser@7.6.0 None +4 1.37 MB jameshenry
npm/@uiw/react-codemirror@4.21.25 None +4 1.16 MB wcjiang
npm/@vercel/frameworks@1.6.0 filesystem Transitive: eval +1 312 kB vercel-release-bot
npm/@vercel/fs-detectors@4.1.3 environment, filesystem, shell +2 277 kB vercel-release-bot
npm/@vercel/stega@0.1.0 None 0 25.4 kB vercel-release-bot
npm/@vitejs/plugin-react@4.2.1 None +3 64.1 kB vitebot
npm/@vvo/tzdb@6.131.0 None 0 175 kB vvo
npm/archiver@7.0.1 filesystem +2 863 kB ctalkington
npm/arrify@2.0.1 None 0 3.19 kB sindresorhus
npm/async-mutex@0.4.1 None 0 54.7 kB dirtyhairy
npm/boxen@4.2.0 None +1 20.3 kB sindresorhus

🚮 Removed packages: npm/chalk@4.1.2, npm/clean-stack@3.0.1, npm/debug@3.2.7, npm/glob@7.2.3, npm/import-fresh@3.3.0, npm/js-yaml@4.1.0, npm/leven@3.1.0, npm/lodash@4.17.21, npm/minimist@1.2.8, npm/open@8.4.2, npm/p-filter@2.1.0, npm/pirates@4.0.6, npm/read-pkg-up@7.0.1, npm/resolve-from@5.0.0, npm/rimraf@3.0.2, npm/which@2.0.2

View full report↗︎

@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 26, 2024 •
edited

Component Testing Report Updated Apr 29, 2024 5:52 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 35s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 20s 6 3 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 35s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 5s 14 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 4s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 20s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 22s 9 0 0

@rexxars rexxars requested a review from a team as a code owner April 26, 2024 23:33
pedrobonamin
pedrobonamin approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@pedrobonamin pedrobonamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Any reason why we are not updating https://github.com/sanity-io/sanity/blob/chore/react-upgrade/dev/test-next-studio/package.json#L16 to latest?

@rexxars
Copy link
Member Author

rexxars commented Apr 29, 2024

Any reason why we are not updating https://github.com/sanity-io/sanity/blob/chore/react-upgrade/dev/test-next-studio/package.json#L16 to latest?

Just an oversight. Will fix.

@rexxars rexxars added this pull request to the merge queue Apr 29, 2024
Merged via the queue into next with commit 9e2cf15 Apr 29, 2024
39 checks passed
@rexxars rexxars deleted the chore/react-upgrade branch April 29, 2024 17:53
cngonzalez pushed a commit that referenced this pull request May 8, 2024
@rexxars @cngonzalez
chore(deps): upgrade to react 18.3.1 (#6505)
463b6fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobonamin pedrobonamin pedrobonamin approved these changes

@bjoerge bjoerge Awaiting requested review from bjoerge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rexxars @pedrobonamin