-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): skip reset presence selection on PTE blur #6511
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
No changes to documentation |
Component Testing Report Updated Apr 29, 2024 2:31 PM (UTC)
|
@hermanwikner this makes sense to me, and have tested to verify it's now resolved, but @skogsmaskin probably best to ratify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description
This pull request resolves an issue where the popover for editing objects in the PTE closes immediately after opening. This issue was introduced with the implementation of presence cursors, where the
onPathFocus
function is called to reset theselection
presence state when the PTE input is blurred. The fix here is to avoid resetting the presence selection on blur, and instead, allow the selection to be reset when another input is focused, thereby updating the presence.What to review
Notes for release
N/A