Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): skip reset presence selection on PTE blur #6511

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

hermanwikner
Copy link
Member

@hermanwikner hermanwikner commented Apr 29, 2024

Description

This pull request resolves an issue where the popover for editing objects in the PTE closes immediately after opening. This issue was introduced with the implementation of presence cursors, where the onPathFocus function is called to reset the selection presence state when the PTE input is blurred. The fix here is to avoid resetting the presence selection on blur, and instead, allow the selection to be reset when another input is focused, thereby updating the presence.

What to review

  • Ensure that editing objects in the PTE (such as links) is possible.

Notes for release

N/A

Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Apr 29, 2024 2:28pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 2:28pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 2:28pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Apr 29, 2024 2:28pm

Copy link
Contributor

No changes to documentation

@hermanwikner hermanwikner marked this pull request as ready for review April 29, 2024 14:24
@hermanwikner hermanwikner requested a review from a team as a code owner April 29, 2024 14:24
@hermanwikner hermanwikner requested review from jordanl17 and skogsmaskin and removed request for a team April 29, 2024 14:24
Copy link
Contributor

github-actions bot commented Apr 29, 2024

Component Testing Report Updated Apr 29, 2024 2:31 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 40s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 7s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 28s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 20s 6 3 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 36s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 4s 14 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 5s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 21s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 15s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 23s 9 0 0

@jordanl17
Copy link
Member

@hermanwikner this makes sense to me, and have tested to verify it's now resolved, but @skogsmaskin probably best to ratify

Copy link
Member

@skogsmaskin skogsmaskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hermanwikner hermanwikner added this pull request to the merge queue Apr 29, 2024
Merged via the queue into next with commit f0c94f1 Apr 29, 2024
39 checks passed
@hermanwikner hermanwikner deleted the edx-1277 branch April 29, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants