fix: use discard in delete action when document is not published #6535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
cngonzalez
commented
Apr 30, 2024
| return vXClient.observable.request({ | ||
| url: `/data/actions/${dataset}`, | ||
| method: 'post', | ||
| tag: 'document.delete', |
There was a problem hiding this comment.
I've maintained the tag as document.delete so we have a sense of what the user's intent was. We can change it to document.discard if we don't like this choice.
There was a problem hiding this comment.
I don't see a problem with changing this to "document.discard", The fact that the button says "Delete" in this case feels more coincidental, and you could argue that it might as well say "Discard draft" when there is no published document.
|
No changes to documentation |
|
Component Testing Report Updated May 6, 2024 10:13 PM (UTC)
|
bjoerge
approved these changes
May 6, 2024
cngonzalez
force-pushed
the
sdx-1309/use-discard-in-delete
branch
from
7c7c8a8
to
fc45d71
Compare
This was referenced May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
deleteaction in server side document actions requires a published document. In those cases when there is not a published document, we can't use this endpoint.This PR adds logic for those cases by using the discard endpoint instead, and adds a few tests.
What to review
That the logic makes sense and this is how we want to proceed. We can always work with other teams to ensure we're doing something semantic that won't hinder us later.
Testing
This PR adds two tests for the delete action.