Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cliInitializedAt field to project metadata #6538

Merged
merged 2 commits into from
May 3, 2024
Merged

feat: add cliInitializedAt field to project metadata #6538

merged 2 commits into from
May 3, 2024

Conversation

svirs
Copy link
Contributor

@svirs svirs commented May 1, 2024

Description

Updates project metadata to indicate the project has been initialized locally

What to review

Backend errors should not interrupt project init flow under any circumstances

@svirs svirs requested a review from a team as a code owner May 1, 2024 17:27
@svirs svirs requested review from cngonzalez and removed request for a team May 1, 2024 17:27
@vercel Vercel
Copy link

vercel bot commented May 1, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview May 3, 2024 4:25pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 4:25pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 4:25pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview May 3, 2024 4:25pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 1, 2024

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 1, 2024 •
edited

Component Testing Report Updated May 3, 2024 4:28 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 36s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 20s 6 3 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 35s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 3s 14 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 5s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 20s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 15s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 22s 9 0 0

cngonzalez
cngonzalez approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@cngonzalez cngonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable to me!

@svirs
Copy link
Contributor Author

svirs commented May 2, 2024

Will need to do a small update, also pending this client change for type information: sanity-io/client#779

@svirs svirs requested a review from cngonzalez May 2, 2024 16:50
@svirs
Copy link
Contributor Author

svirs commented May 3, 2024

Rebased and removed updated @sanity/client commit

@svirs svirs added this pull request to the merge queue May 3, 2024
Merged via the queue into next with commit 15486f7 May 3, 2024
39 checks passed
@svirs svirs deleted the gro-1902 branch May 3, 2024 17:21
This was referenced May 31, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cngonzalez cngonzalez Awaiting requested review from cngonzalez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@svirs @cngonzalez