Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typegen): pass resolved path instead of the imported path #6540

Merged
merged 1 commit into from
May 2, 2024

Conversation

sgulseth
Copy link
Member

@sgulseth sgulseth commented May 1, 2024

Description

We were passing the relative imported file path instead of the resolved file path, this prevents imported modules from importing other relative files.

Reported here

What to review

Testing

Added 👍

Notes for release

typegen: Fixed a bug where importing a variable inside an imported file would fail

@sgulseth sgulseth requested a review from a team as a code owner May 1, 2024 20:42
Copy link

vercel bot commented May 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview May 1, 2024 8:46pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 8:46pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 8:46pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) May 1, 2024 8:46pm

Copy link
Contributor

github-actions bot commented May 1, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented May 1, 2024

Component Testing Report Updated May 1, 2024 8:52 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 34s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 25s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 19s 6 3 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 35s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 5s 14 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 6s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 20s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 22s 9 0 0

@sgulseth sgulseth added this pull request to the merge queue May 2, 2024
Merged via the queue into next with commit e7ffe93 May 2, 2024
39 checks passed
@sgulseth sgulseth deleted the fix/typegen/import-filename branch May 2, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants