Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[components] Make arrow ignore pointer-event and clicks the select #656

Merged
merged 1 commit into from
Mar 13, 2018
Merged

[components] Make arrow ignore pointer-event and clicks the select #656

merged 1 commit into from
Mar 13, 2018

Conversation

kristofferjs
Copy link
Contributor

No description provided.

@bjoerge
Copy link
Member

bjoerge commented Mar 13, 2018

What does this fix?

@kristofferjs
Copy link
Contributor Author

kristofferjs commented Mar 13, 2018 •
edited by bjoerge

This fixes that the arrow on DefaultSelect does not open the <select>. This fix sets pointer-events to none. That means that clicking the arrow is the same as clicking the <select>, and will open the <select>

@bjoerge
Copy link
Member

bjoerge commented Mar 13, 2018

Thanks! LGTM.

@kristofferjs kristofferjs merged commit e178271 into next Mar 13, 2018
@kristofferjs kristofferjs deleted the fix/clickable-select-arrow branch March 13, 2018 13:57
bjoerge pushed a commit that referenced this pull request Mar 15, 2018
@bjoerge
[components] Make arrow ignore pointer-event and clicks the select (#656
343e11c 
)
@snyk-bot snyk-bot mentioned this pull request Dec 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoerge bjoerge bjoerge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kristofferjs @bjoerge