feat(pte): create new text blocks if needed #6560
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated May 3, 2024 5:03 PM (UTC)
|
pedrobonamin
requested review from
jtpetty and
skogsmaskin
and removed request for
a team
There was a problem hiding this comment.
This looks good to me, but would want @skogsmaskin to review as well. Thanks for writing so many tests for this fix.
| onClick(event) | ||
| } | ||
| // Inserts a new block if it's clicking on the editor, focused on the last block and it's a void element | ||
| if (slateEditor.selection && event.target === event.currentTarget) { |
There was a problem hiding this comment.
PK will likely be the best person, but I wonder if this could be something that was moved to a normalise function :)
There was a problem hiding this comment.
Curious to that answer, but I think it's not possible. as this is handling the onClick event.
It tries to solve the action in which the user clicks below the void block and nothing is added, so he can't continue typing.
The first part of the video is current behaviour, second part is with the changes.
Screen.Recording.2024-05-06.at.14.09.42.mov
There was a problem hiding this comment.
It's a timely question @RitaDias!
However in this case I think we don't want normalization. We want it to be tied to the UI-event of the user trying to click of move below with the intention of creating a new block.
We don't in all cases want it to always insert a empty block there (that would mean it's impossible to end a editor with an object block).
Description
This changes improve the editor experience by adding empty text blocks into PTE when needed.
A new block is added if the user is focused on the last block which is void, and clicks in the editor.
Adds.new.block.at.the.end.mov
A new block is added if the user is focused on the last block which is void, and presses arrow down.
Screen.Recording.2024-05-03.at.12.47.05.mov
A new block is added at the top, when pressing arrow up, because first block is void, the new block can be deleted with backspace.
Screen.Recording.2024-05-03.at.12.43.48.mov
What to review
Testing
Notes for release