Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tasks): update tasks panel z index #6571

Merged
merged 1 commit into from
May 6, 2024
Merged

fix(tasks): update tasks panel z index #6571

merged 1 commit into from
May 6, 2024

Conversation

pedrobonamin
Copy link
Contributor

Description

Updates tasks sidebar z index to sit on top of the rest of elements.

What to review

Testing

Notes for release

@pedrobonamin pedrobonamin requested a review from a team as a code owner May 6, 2024 06:55
@pedrobonamin pedrobonamin requested review from jordanl17 and removed request for a team May 6, 2024 06:55
@vercel Vercel
Copy link

vercel bot commented May 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview May 6, 2024 6:55am
test-next-studio ✅ Ready (Inspect) Visit Preview May 6, 2024 6:55am
test-studio ✅ Ready (Inspect) Visit Preview May 6, 2024 6:55am
1 Ignored Deployment
Name Status Preview Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) May 6, 2024 6:55am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024

Component Testing Report Updated May 6, 2024 7:03 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 34s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 19s 6 3 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 35s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 3s 14 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 4s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 20s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 21s 9 0 0

RitaDias
RitaDias reviewed May 6, 2024
View reviewed changes
packages/sanity/src/core/tasks/plugin/TasksStudioActiveToolLayout.tsx
@@ -77,6 +77,7 @@ function TasksStudioActiveToolLayoutInner(props: ActiveToolLayoutProps) {
{isOpen && (
<SidebarMotionLayer
animate="visible"
zOffset={1000}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedrobonamin 👋 Quick question: which issue is this trying to solve? 👀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋🏻
Screenshot 2024-04-17 at 15 47 19

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some elements are showing on top of the tasks sidebar.

RitaDias
RitaDias approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@RitaDias RitaDias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@pedrobonamin pedrobonamin added this pull request to the merge queue May 6, 2024
Merged via the queue into next with commit 3b3125c May 6, 2024
40 checks passed
@pedrobonamin pedrobonamin deleted the edx-1254 branch May 6, 2024 12:06
This was referenced May 31, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RitaDias RitaDias RitaDias approved these changes

@jordanl17 jordanl17 Awaiting requested review from jordanl17 jordanl17 is a code owner automatically assigned from sanity-io/studio-ex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pedrobonamin @RitaDias