feat(cli): remove is-builtin-module #6579
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
is-builtin-module
package since all node versions within ourengine
constraint already have such a function built in.This also allows us to remove the temporary workaround we had around
string_decoder/
since the built in function will not have such a bug.What to review
The CLI should be the only affected package.
Testing
Existing tests should cover this.
Notes for release
N/A