Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(form): fix issue making circular structures sometimes causing infinite loop #6699

Merged
merged 2 commits into from
May 27, 2024
Merged

fix(form): fix issue making circular structures sometimes causing infinite loop #6699

merged 2 commits into from
May 27, 2024

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented May 16, 2024

Description

This PR adds the fix and unit test proposed in #6646 with a few minor modifications, mostly in order to align it with established coding conventions. See #6646 for an in-depth explanation of the issue.

What to review

Does the changes make sense?

Testing

A unit test asserting the correct behavior is included.

Notes for release

Fixes an issue that could under certain conditions cause a circular structure to enter an infinite loop. Shoutout to @sarahsvedenborg and @stian-svedenborg for identifying the issue and proposing a fix.

@bjoerge bjoerge requested a review from a team as a code owner May 16, 2024 12:29
@bjoerge bjoerge requested review from juice49 and removed request for a team May 16, 2024 12:29
@vercel Vercel
Copy link

vercel bot commented May 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2024 11:15am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2024 11:15am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2024 11:15am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2024 11:15am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview May 27, 2024 11:15am

@bjoerge bjoerge linked an issue May 16, 2024 that may be closed by this pull request
Hang introduced by #5269, (a0f93cb) (fix included) #6646
Closed
@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 16, 2024 •
edited
Loading

Component Testing Report Updated May 27, 2024 11:18 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 39s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 31s 11 7 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 36s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 16s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 5s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 7s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 21s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 15s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 30s 12 0 0

juice49
juice49 approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@juice49 juice49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

bjoerge and others added 2 commits May 27, 2024 13:05
@bjoerge bjoerge requested a review from skogsmaskin May 27, 2024 11:10
skogsmaskin
skogsmaskin approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@skogsmaskin skogsmaskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bjoerge bjoerge added this pull request to the merge queue May 27, 2024
Merged via the queue into next with commit 7efdeeb May 27, 2024
43 checks passed
@bjoerge bjoerge deleted the sdx-1335 branch May 27, 2024 12:27
@leocabrallce leocabrallce mentioned this pull request Jun 20, 2024
Open
This was referenced Jun 24, 2024
Open
Open
@leocabrallce leocabrallce mentioned this pull request Jun 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skogsmaskin skogsmaskin skogsmaskin approved these changes

@juice49 juice49 juice49 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hang introduced by #5269, (a0f93cb) (fix included)
3 participants
@bjoerge @skogsmaskin @juice49