fix(structure): fixing incorrect way of setting col visibility #6716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated May 21, 2024 9:44 AM (UTC)
|
binoy14
reviewed
May 20, 2024
| @@ -20,7 +21,7 @@ describe('useDocumentSheetColumns', () => { | |||
| {name: 'email', type: {name: 'string'}}, | |||
| {name: 'age', type: {name: 'number'}}, | |||
| { | |||
| name: 'address', | |||
| name: 'address.place', | |||
There was a problem hiding this comment.
This type of schema name won't be allowed in the studio, it doesn't support dot notation in the naems
There was a problem hiding this comment.
- tests don't need to test with dot notation
| @@ -156,17 +160,19 @@ export function useDocumentSheetColumns(documentSchemaType?: ObjectSchemaType) { | |||
| () => | |||
| flatColumns(columns).reduce<[VisibilityState, number]>( | |||
| ([accCols, countAllowedVisible], column) => { | |||
| const visibilityKey = String(column.id) | |||
There was a problem hiding this comment.
Column id is possibly undefined according to the tanstack column definition and accessor functions, thinking on throwing an error if it doesn't have a column.id
We are controlling this, but in case something changes in the future it will be simpler to identify the problem if for some case the id is missing.
There was a problem hiding this comment.
- throw if there's not an ID on a column
pedrobonamin
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue introduced in EDX-1308 (#6661) where tanstack col visibility expects field separator as
_but incorrectly.was being used for our definitionsWhat to review
Defining an id for all cols which is used in flatColumns.
Selected column now a display column
Testing
Updated test case
Notes for release
Not relevant - this feature is not yet user facing