fix(types): correct ArrayOptions
#6737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated May 30, 2024 10:38 AM (UTC)
|
rexxars
changed the title
ArrayOptions
juice49
requested changes
May 30, 2024
There was a problem hiding this comment.
Thanks, Christian! This looks great, and does more closely reflect the underlying functionality.
Instead of removing direction, please can you mark is as deprecated? Removing it is technically a breaking change to the API, even though it doesn't actually do anything.
christianhg
force-pushed
the
adjust-array-options
branch
from
74748cc
to
dacdb0b
Compare
Thanks for the feedback! I've deprecated the option now, instead of removing it. |
juice49
reviewed
May 30, 2024
christianhg
force-pushed
the
adjust-array-options
branch
from
dacdb0b
to
1bdfa40
Compare
- Removed the comment about `layout` since it's confusing/wrong. The `grid` option also works for a string array. - Added `list` as a valid `layout` option. Even though it's the default, it feels weird that you can't specify it manually. - Deprecated `direction` since it doesn't do anything anymore.
christianhg
force-pushed
the
adjust-array-options
branch
from
1bdfa40
to
85d5365
Compare
juice49
approved these changes
May 30, 2024
Thank you! Feel free to merge it on my behalf. I don't have permissions to do so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
layoutsince it's confusing/wrong. Thegridoption also works for a string array.listas a validlayoutoption. Even though it's the default, it feels weird that you can't specify it manually.directionsince it doesn't seem to do anything. Maybe it's old?I realise that (a) this might be a bold change and (b) I might have no idea what I'm doing since I'm relatively new here, but these changes are based on my observations as I work with the Array schema type and read through https://www.sanity.io/docs/array-type