-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: change the action to use warnings and only fail on new ones #6740
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
No changes to documentation |
002a736
to
f475719
Compare
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
f475719
to
975d6c2
Compare
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
Component Testing Report Updated May 22, 2024 5:32 PM (UTC)
|
@SocketSecurity ignore-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to me, thanks!
Refactors the React Compiler CI check to no longer always fail, it now uses warnings.
It uses
--max-warnings
to prevent new code from introducing new issues.The downside to this is that if issues are fixed it's important to decrement this number (currently
49
) otherwise new issues can be silently introduced.It also sets up a GitHub problem matcher called
eslint-compact.json
which allows the actions to show up on the PR diff itself. It might also work for the regularpnpm lint
command but I haven't tested it as it's a bit out of scope.Failed checks show up inline on the PR, even though they are warnings:
![image](https://private-user-images.githubusercontent.com/81981/332876164-6017edfa-8609-4a5c-a680-f7fcdbccf0de.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAwMjMwNjcsIm5iZiI6MTcyMDAyMjc2NywicGF0aCI6Ii84MTk4MS8zMzI4NzYxNjQtNjAxN2VkZmEtODYwOS00YTVjLWE2ODAtZjdmY2RiY2NmMGRlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzAzVDE2MDYwN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ3NDU1M2Y1MGQ5YWJiMmFjZWFlMzZiMjczMjRlNzhjY2JkYTA0MDMzM2FiYTljMDYyNGIwYjY2YmNkMDg1ZmMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.VHtwLeMlQd5nJN-KRJC0V0xrivyHTMUZY9gHTAfPPWI)
It ignores comments that silences the check (we don't allow this):
![image](https://private-user-images.githubusercontent.com/81981/332878276-e699c128-3c5d-4969-b851-21fbe2a1a9ca.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAwMjMwNjcsIm5iZiI6MTcyMDAyMjc2NywicGF0aCI6Ii84MTk4MS8zMzI4NzgyNzYtZTY5OWMxMjgtM2M1ZC00OTY5LWI4NTEtMjFmYmUyYTFhOWNhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzAzVDE2MDYwN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA0OWFkY2M1NjE2M2NjZjQ4MDM2YTM5OTgyZGI1MTQ4YTBjM2E3NzVmZTc0NGRmMWVlYThmMTk2YzUxYjUxNTYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.pIeIHuMtF8ZTCuEthNIHRwyj2tbz6SHmYnGtMf5t8CU)