feat: create import map w/ installed sanity version #6784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated May 28, 2024 5:28 PM (UTC)
|
binoy14
requested changes
May 28, 2024
| const version = encodeURIComponent(`^${installedSanityVersion}`) | ||
| const autoUpdatesImports = { | ||
| // /:packageName/:channel/:minVersion/:file? | ||
| 'sanity': `https://api.sanity.work/v1/sanity/default/${version}`, |
There was a problem hiding this comment.
The URL is incorrect for all, missing modules
Suggested change
| 'sanity': `https://api.sanity.work/v1/sanity/default/${version}`, | |
| 'sanity': `https://api.sanity.work/v1/modules/sanity/default/${version}`, |
binoy14
approved these changes
May 28, 2024
ricokahler
added a commit
that referenced
this pull request
May 28, 2024
* feat(cli): build user peer-deps * chore: remove shared-modules build * test(cli): verify build config and `exports` subpaths * text(cli): add depcheck config for fixture projects * docs: update comments and test name * feat: create import map w/ installed sanity version (#6784) * feat: create import map w/ installed sanity version * fix: use correct URL
binoy14
pushed a commit
that referenced
this pull request
May 28, 2024
* feat(cli): build user peer-deps * chore: remove shared-modules build * test(cli): verify build config and `exports` subpaths * text(cli): add depcheck config for fixture projects * docs: update comments and test name * feat: create import map w/ installed sanity version (#6784) * feat: create import map w/ installed sanity version * fix: use correct URL
binoy14
pushed a commit
that referenced
this pull request
May 29, 2024
* feat(cli): build user peer-deps * chore: remove shared-modules build * test(cli): verify build config and `exports` subpaths * text(cli): add depcheck config for fixture projects * docs: update comments and test name * feat: create import map w/ installed sanity version (#6784) * feat: create import map w/ installed sanity version * fix: use correct URL
binoy14
pushed a commit
that referenced
this pull request
May 30, 2024
* feat(cli): build user peer-deps * chore: remove shared-modules build * test(cli): verify build config and `exports` subpaths * text(cli): add depcheck config for fixture projects * docs: update comments and test name * feat: create import map w/ installed sanity version (#6784) * feat: create import map w/ installed sanity version * fix: use correct URL
binoy14
pushed a commit
that referenced
this pull request
May 30, 2024
* feat(cli): build user peer-deps * chore: remove shared-modules build * test(cli): verify build config and `exports` subpaths * text(cli): add depcheck config for fixture projects * docs: update comments and test name * feat: create import map w/ installed sanity version (#6784) * feat: create import map w/ installed sanity version * fix: use correct URL
binoy14
pushed a commit
that referenced
this pull request
May 31, 2024
* feat(cli): build user peer-deps * chore: remove shared-modules build * test(cli): verify build config and `exports` subpaths * text(cli): add depcheck config for fixture projects * docs: update comments and test name * feat: create import map w/ installed sanity version (#6784) * feat: create import map w/ installed sanity version * fix: use correct URL
binoy14
pushed a commit
that referenced
this pull request
Jun 10, 2024
* feat(cli): build user peer-deps * chore: remove shared-modules build * test(cli): verify build config and `exports` subpaths * text(cli): add depcheck config for fixture projects * docs: update comments and test name * feat: create import map w/ installed sanity version (#6784) * feat: create import map w/ installed sanity version * fix: use correct URL
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
* feat: add CLI options to enable auto-updating studios * refactor(cli): prefix with `unstable_` * test: Update packages/sanity/src/_internal/cli/server/renderDocument.ts Co-authored-by: Espen Hovlandsdal <espen@hovlandsdal.com> * chore(core): update import map urls * feat(cli): build user peer-deps (#6742) * feat(cli): build user peer-deps * chore: remove shared-modules build * test(cli): verify build config and `exports` subpaths * text(cli): add depcheck config for fixture projects * docs: update comments and test name * feat: create import map w/ installed sanity version (#6784) * feat: create import map w/ installed sanity version * fix: use correct URL * chore(cli): rename auto updates flag --------- Co-authored-by: Espen Hovlandsdal <espen@hovlandsdal.com> Co-authored-by: Binoy Patel <me@binoy.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the minimum version to the import map grabbed from the installed sanity version.
What to review
Try the build action out, try the deploy action out with auto updates.
Testing
Tested it in by building the test-studio with --enable-auto-updates (flag needs to be renamed but will come in another PR)
Notes for release
N/A