fix(@sanity): _regenerateKeys so that the MarkDefs left are only those allowed

[RitaDias]

Description

Add fix for when PTE text is pasted from one input to another that it respects the allowed annotations

Before

Screen.Recording.2024-05-21.at.14.mp4

Testing

The added tests should be sufficient

• Added tests to _regenerateKeys (test before normalization)
• The normalization tests already test for the "after normalization" -> preserves other marks that apply to the spans

While the original issue was detected on copy paste, I don't think it is necessary to add a test to target that use case in particular. We would have seen this as an issue when creating a doc via the terminal for example.

Notes for release

Fixes issue where when PTE text was copy pasted always kept the original annotations regardless of the receiving PTE customization

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
page-building-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 20, 2024 11:22am
performance-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 20, 2024 11:22am
test-compiled-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 20, 2024 11:22am
test-next-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 20, 2024 11:22am
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 20, 2024 11:22am

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)	Visit Preview		Jun 20, 2024 11:22am

[github-actions]

No changes to documentation

[github-actions]

Component Testing Report Updated Jun 20, 2024 11:30 AM (UTC)

File	Status	Duration	Passed	Skipped	Failed
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	44s	14	0	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	7s	3	0	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	27s	6	0	0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	32s	11	7	0
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	14s	6	0	0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx	✅ Passed (Inspect)	9s	3	0	0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx	✅ Passed (Inspect)	52s	1	0	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	36s	15	0	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	1m 15s	20	0	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	1m 5s	18	0	0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx	✅ Passed (Inspect)	7s	3	9	0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx	✅ Passed (Inspect)	21s	9	0	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	15s	6	0	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	1m 4s	21	0	0

[skogsmaskin]

@RitaDias - I'm wondering if it makes more sense to build you code into the normalizeBlock function in @sanity/block-tools. It's already doing the same for decorator marks, and I think your code would be a great addition to that function.

It's already being used for the pasted content.

[RitaDias]

Member

Just had a chat with @skogsmaskin and it's best to keep it as it is since copy / pasting from PTE to anoter PTE doesn't run the normalizeBlock

[christianhg]

@RitaDias , any chance I could get you to open this PR against https://github.com/portabletext/editor instead? Then we don't have to port these changes to that repo/package after #7001 has been merged.

Sorry for the inconvenience :(

[RitaDias]

@RitaDias , any chance I could get you to open this PR against https://github.com/portabletext/editor instead? Then we don't have to port these changes to that repo/package after #7001 has been merged.

Sorry for the inconvenience :(

I'll do that :)

[RitaDias]

Closing this, re-opened it on portabletext/editor#19 :)