[chore] Avoid mixed export/imports #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rexxars
added a commit
that referenced
this pull request
Apr 9, 2018
kristofferjs
pushed a commit
that referenced
this pull request
Apr 12, 2018
kristofferjs
pushed a commit
that referenced
this pull request
Apr 12, 2018
* [form-builder] Conflicting name causes radiobuttons not to focus * [components] Styling focus after selectContainer is removed * [form-builder] Requests from PR * [import] Support importing from folder * [core] Allow importing datasets from directory * [core] Improve `sanity dataset import` documentation * [validation] Allow unicode in URIs * [chore] Avoid mixed export/imports (#699) * [image-url] Fix parsing image source (#728) * [image-url] Fix parsing image source * [image-url] Remove only from test case and change comprison operators to triple equal in parseSource * [components] Styling focus state on select (#682) * [server] Allow specifying a basePath for a studio (#720) * [server] Allow specifying a basePath for a studio * [default-layout] Resolve and use base path for studio if specified * [image-url] Code style fixes * v0.128.12 * [cli] Allow using template flag in interactive mode * v0.128.13
bjoerge
pushed a commit
that referenced
this pull request
Apr 19, 2018
* [form-builder] Conflicting name causes radiobuttons not to focus * [components] Styling focus after selectContainer is removed * [form-builder] Requests from PR * [import] Support importing from folder * [core] Allow importing datasets from directory * [core] Improve `sanity dataset import` documentation * [validation] Allow unicode in URIs * [chore] Avoid mixed export/imports (#699) * [image-url] Fix parsing image source (#728) * [image-url] Fix parsing image source * [image-url] Remove only from test case and change comprison operators to triple equal in parseSource * [components] Styling focus state on select (#682) * [server] Allow specifying a basePath for a studio (#720) * [server] Allow specifying a basePath for a studio * [default-layout] Resolve and use base path for studio if specified * [image-url] Code style fixes * v0.128.12 * [cli] Allow using template flag in interactive mode * v0.128.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes a couple of default exports in the form builder as a named export as well and changes the imports to use the named form. This will make it easier to (possibly) move to a new parts implementation.