fix: remove trailing commas when sanitizing #7007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Jun 21, 2024 2:23 PM (UTC)
|
binoy14
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove trailing commas on Journey schema sanitizer as this in will output invalid code that makes Prettier throw in certain cases.
This is a schema that would previously throw:
[{"name":"post","title":"Post","type":"document","fields":[{"name":"title","title":"Title","type":"string"},{"name":"slug","title":"Slug","type":"slug","options":{"source":"title","maxLength":96}},{"name":"author","title":"Author","type":"reference","to":{"type":"author"}},{"name":"mainImage","title":"Main image","type":"image","options":{"hotspot":true}},{"name":"categories","title":"Categories","type":"array","of":[{"type":"reference","to":{"type":"category"}}]},{"name":"publishedAt","title":"Published at","type":"datetime"},{"name":"body","title":"Body","type":"blockContent"}]},{"name":"author","title":"Author","type":"document","fields":[{"name":"name","title":"Name","type":"string"},{"name":"slug","title":"Slug","type":"slug","options":{"source":"name","maxLength":96}},{"name":"image","title":"Image","type":"image","options":{"hotspot":true}},{"name":"bio","title":"Bio","type":"array","of":[{"title":"Block","type":"block","styles":[{"title":"Normal","value":"normal"}],"lists":[]}]}],"preview":{"select":{"title":"name","media":"image"}}},{"name":"category","title":"Category","type":"document","fields":[{"name":"title","title":"Title","type":"string"},{"name":"description","title":"Description","type":"text"}]},{"title":"Block Content","name":"blockContent","type":"array","of":[{"title":"Block","type":"block","styles":[{"title":"Normal","value":"normal"},{"title":"H1","value":"h1"},{"title":"H2","value":"h2"},{"title":"H3","value":"h3"},{"title":"H4","value":"h4"},{"title":"Quote","value":"blockquote"}],"lists":[{"title":"Bullet","value":"bullet"}],"marks":{"decorators":[{"title":"Strong","value":"strong"},{"title":"Emphasis","value":"em"}],"annotations":[{"title":"URL","name":"link","type":"object","fields":[{"title":"URL","name":"href","type":"url"}]}]}},{"type":"image","options":{"hotspot":true}}]}]What to review
Tbd
Testing
CLI is lacking tests in general, but the plan is to write tests for this journey flow as a follow-up PR very soon.
Notes for release
Tbd