[import] Fix JSON parse errors not being emitted #703
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the new "peek at the stream to see if it's an ndjson or a tarball" behavior, JSON parse errors were not being surfaced. With this PR we apply a separate error handler on the ndjson stream and reject if encountering any errors. Because the concatenation stream finishes prior to the pipeline callback, I had to slightly change the flow to assign the gathered JSON-documents to a variable and resolving only on pipeline completion.