Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix lint warning in WithAddonDatasetProvider #7240

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

pedrobonamin
Copy link
Contributor

Description

HOC WithAddonDatasetProvider is read as a component instead of a HOC because it starts with a capital letter, so react compiler exposes an error because of the name mutation.
Changing the WithAddonDatasetProvider to lowercase withAddonDatasetProvider fixes the issue


Screenshot 2024-07-24 at 16 00 27
Screenshot 2024-07-24 at 16 00 35

What to review

Testing

Notes for release

@pedrobonamin pedrobonamin requested a review from a team as a code owner July 24, 2024 14:04
@pedrobonamin pedrobonamin requested review from ricokahler and removed request for a team July 24, 2024 14:04
Copy link

vercel bot commented Jul 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 2:09pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 2:09pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 2:09pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 2:09pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 2:09pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Jul 24, 2024 2:09pm

Copy link
Contributor

No changes to documentation

@pedrobonamin pedrobonamin merged commit eab5c75 into corel Jul 25, 2024
38 of 41 checks passed
@pedrobonamin pedrobonamin deleted the fix-corel-displayname branch July 25, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants