[cli] Don't show upgrade prompt on same version #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rexxars
force-pushed
the
cli-skip-notify-on-same-version
branch
from
29aa2f1
to
ba8cad2
Compare
rexxars
changed the title
rexxars
force-pushed
the
cli-skip-notify-on-same-version
branch
from
ba8cad2
to
91958a5
Compare
bjoerge
pushed a commit
that referenced
this pull request
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain edge cases, we displayed a prompt telling the user that an upgrade was available when it actually wasn't. This PR checks whether we have a diff in the versions before prompting.