[cli] Delete Sanity-modules that needs upgrading to work around yarn bug #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should go into master and be released immediately, maybe? |
rexxars
force-pushed
the
fix-yarn-upgrade-bug
branch
from
dce1716
to
6207a10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes:
sanity upgrade, it previously included@sanity/cliin the output, which was very misleading.sanity upgrade, we've encountered an inexplicable bug where yarn will upgrade the lockfile with the resolved tarball URL and version, but will somehow not extract and replace the installed module. Withdce1716, we will delete the modules that need to be upgraded before actually runningyarnto work around this bug.This once again puts some further pressure on prioritizing #716