Styleselect and official react popper #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kristofferjs
commented
May 3, 2018
kristofferjs
commented
- Fixing style select (the one in block editor)
- Using official react-popper
bjoerge
approved these changes
May 3, 2018
| <div ref={this.setPopperElement}> | ||
| <List className={styles.list}> | ||
| {items.map((item, index) => { | ||
| const isSemiSelected = value && value.length > 1 && includes(value, item) |
There was a problem hiding this comment.
Could you use value.includes(item) here instead?
Edit: I see now that this was not added in this PR. Bonus point if you would like to change it to value.includes(item) still
bjoerge
pushed a commit
that referenced
this pull request
May 14, 2018
* [components] Using official react-popper * [components] Fixing styleselect with react-popper * [components] Using native includes instead of lodash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.