Fix image url error when missing crop or hotspot #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristofferjs
pushed a commit
that referenced
this pull request
Sep 3, 2018
* [image-url] Upgrade to latest jest * [image-url] Add failing test and use snapshots instead * [image-url] Fix error caused by missing crop or hotspot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an error that happened if image url builder was passed an image with either
hotspotorcropbut not both.While I was at it, I took the liberty to upgrade jest (which fixes the notorious
SecurityError: localStorage is not available for opaque origins- error) and switched to using jest snapshots instead of hard coded expected return values.