[cli] Fix validation check that would silently crash on windows #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some obscure reason, when using
fse.readdir()where it returnsENOENT, the whole process would just silently crash/exit on windows with no meaningful error. I'll try to debug the problem in more depth, but for now I've switched to using plain oldfs.readdirSync()which seems to work fine.Edit: I also snuck in a few readability tweaks, and most importantly fixed a bug where when specifying
--datasetit would still prompt for dataset visibility when the dataset already exists, which makes no sense.Also the
--output-pathflag would only work in unattended mode, but will now work regardless.