[schema] Always define hotspot/crop fields for image type #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simen
approved these changes
Sep 26, 2018
bjoerge
reviewed
Sep 27, 2018
rexxars
force-pushed
the
set-hotspot-fields-as-hidden
branch
from
03b42c2
to
0ccc939
Compare
bjoerge
pushed a commit
that referenced
this pull request
Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we do not define the crop and hotspot fields on an image type if the hotspot option is not set. From a data modelling perspective, it feels more correct to always define them but rather flag them as hidden from a UI perspective.
By doing this, the base
imagetype is always the same unless explicitly extended with other fields, as opposed to two variants which should more correctly have been namedimageandimageWithCropAndHotspotor similar.