Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Its good if this was an actual JQuery Plugin #14

Closed
kasvith opened this issue Feb 22, 2018 · 2 comments
Closed

Its good if this was an actual JQuery Plugin #14

kasvith opened this issue Feb 22, 2018 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@kasvith
Copy link
Collaborator

kasvith commented Feb 22, 2018

jQuery Plugin is needed

Its obvious that this plugin is not binding to jQuery itself.
We need let users to select what element should display the rain, so i suggest to refactor this to be used as like

$('#my-custom-id-div').rain()

@kasvith kasvith added enhancement New feature or request good first issue Good for newcomers labels Feb 22, 2018
@sanjayaharshana
Copy link
Owner

yeah..modified for JQueary Plugin, so when you want to add rain effect your html element. frist thing you should

<script type="text/javascript"> $( "#my-custom-id-div" ).rain({ }); </script>

@kasvith
Copy link
Collaborator Author

kasvith commented Feb 25, 2018

You can close issue now, please mention PR for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants