Make date for Order::withNumberAndDate() optional

Fix #42
sanmai · Apr 19, 2019 · 05a414b · 05a414b
1 parent 390cb57
commit 05a414b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/Common/Order.php b/src/Common/Order.php
@@ -52,7 +52,7 @@ public static function withDispatchNumber(string $DispatchNumber): Order
         ]);
     }
 
-    public static function withNumberAndDate(string $Number, \DateTimeInterface $Date): Order
+    public static function withNumberAndDate(string $Number, \DateTimeInterface $Date = null): Order
     {
         return Order::create([
             'Number' => $Number,

diff --git a/tests/Serialization/OrderTest.php b/tests/Serialization/OrderTest.php
@@ -164,6 +164,17 @@ public function test_can_serialize_with_delivery_surcharge()
   <DeliveryRecipientCostAdv Threshold="2000" Sum="150" VATRate="vat10" VATSum="45.906"/>
   <AddService ServiceCode="30"/>
 </Order>
+', $order);
+    }
+
+    public function test_order_with_number_only()
+    {
+        $order = Order::withNumberAndDate('ORD-123');
+
+        $this->assertSame('ORD-123', $order->getNumber());
+
+        $this->assertSameAsXML('<?xml version="1.0" encoding="UTF-8"?>
+<Order Number="ORD-123"/>
 ', $order);
     }
 }