Revert everything to where it was

sanmai · Oct 15, 2021 · 41433ee · 41433ee
1 parent 5fd95df
commit 41433ee
Show file tree

Hide file tree

Showing 6 changed files with 3 additions and 146 deletions.
diff --git a/src/Process/CoveredPhpProcess.php b/src/Process/CoveredPhpProcess.php
diff --git a/src/Process/Factory/InitialTestsRunProcessFactory.php b/src/Process/Factory/InitialTestsRunProcessFactory.php
@@ -37,7 +37,6 @@
 
 use Composer\InstalledVersions;
 use Infection\AbstractTestFramework\TestFrameworkAdapter;
-use Infection\Process\CoveredPhpProcess;
 use Infection\Process\OriginalPhpProcess;
 use function method_exists;
 use Symfony\Component\Process\Process;
@@ -67,7 +66,7 @@ public function createProcess(
         bool $skipCoverage
     ): Process {
         // If we're expecting to receive a code coverage, test process must run in a vanilla environment
-        $processClass = $skipCoverage ? CoveredPhpProcess::class : OriginalPhpProcess::class;
+        $processClass = $skipCoverage ? Process::class : OriginalPhpProcess::class;
 
         /** @var Process $process */
         $process = new $processClass(

diff --git a/src/TestFramework/Coverage/CoverageChecker.php b/src/TestFramework/Coverage/CoverageChecker.php
@@ -103,7 +103,7 @@ public function checkCoverageRequirements(): void
 Coverage needs to be generated but no code coverage generator (pcov, phpdbg or xdebug) has been detected. Please either:
 - Enable pcov and run Infection again
 - Use phpdbg, e.g. `phpdbg -qrr infection`
-- Enable Xdebug and run Infection again
+- Enable Xdebug (in case of using Xdebug 3 check that `xdebug.mode` or environment variable XDEBUG_MODE set to `coverage`) and run Infection again
 - Use the "--coverage" option with path to the existing coverage report
 - Enable the code generator tool for the initial test run only, e.g. with `--initial-tests-php-options -d zend_extension=xdebug.so`
 TXT

diff --git a/tests/phpunit/Process/CoveredPhpProcessTest.php b/tests/phpunit/Process/CoveredPhpProcessTest.php
diff --git a/tests/phpunit/Process/Factory/InitialTestsRunProcessFactoryTest.php b/tests/phpunit/Process/Factory/InitialTestsRunProcessFactoryTest.php
@@ -36,7 +36,6 @@
 namespace Infection\Tests\Process\Factory;
 
 use Infection\AbstractTestFramework\TestFrameworkAdapter;
-use Infection\Process\CoveredPhpProcess;
 use Infection\Process\Factory\InitialTestsRunProcessFactory;
 use Infection\Process\OriginalPhpProcess;
 use const PHP_OS_FAMILY;
@@ -87,7 +86,6 @@ public function test_it_creates_a_process_with_coverage_skipped(): void
 
         $this->assertNull($process->getTimeout());
         $this->assertNotInstanceOf(OriginalPhpProcess::class, $process);
-        $this->assertInstanceOf(CoveredPhpProcess::class, $process);
     }
 
     public function test_it_creates_a_process_with_coverage(): void

diff --git a/tests/phpunit/TestFramework/Coverage/CoverageCheckerTest.php b/tests/phpunit/TestFramework/Coverage/CoverageCheckerTest.php
@@ -142,7 +142,7 @@ public function test_it_needs_code_coverage_generator_enabled_if_coverage_is_not
 Coverage needs to be generated but no code coverage generator (pcov, phpdbg or xdebug) has been detected. Please either:
 - Enable pcov and run Infection again
 - Use phpdbg, e.g. `phpdbg -qrr infection`
-- Enable Xdebug and run Infection again
+- Enable Xdebug (in case of using Xdebug 3 check that `xdebug.mode` or environment variable XDEBUG_MODE set to `coverage`) and run Infection again
 - Use the "--coverage" option with path to the existing coverage report
 - Enable the code generator tool for the initial test run only, e.g. with `--initial-tests-php-options -d zend_extension=xdebug.so`
 TXT