Ensure generators aren't reused from failed state #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szepeviktor
reviewed
Oct 23, 2023
| @@ -41,7 +42,7 @@ final class Deferred implements Interfaces\Deferred | |||
| private $output; | |||
|
|
|||
| /** | |||
| * @var \Throwable | |||
| * @var ?\Throwable | |||
There was a problem hiding this comment.
In docblock tags it is \Throwable|null
There was a problem hiding this comment.
Somehow Psalm understands ?Type in docblocks 🤔
There was a problem hiding this comment.
Yes it does but if you look a docblocks in other projects, question mark is not used for null.
https://docs.phpdoc.org/guide/references/phpdoc/tags/return.html#return
There was a problem hiding this comment.
There was a problem hiding this comment.
You haven't written ?int below.
There was a problem hiding this comment.
Well, I wasn't going to let it be a docblock forever 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.