take() can safely pass through all iterables, not just traversables

sanmai · Oct 19, 2018 · efcbbec · efcbbec
1 parent 9700386
commit efcbbec
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/functions.php b/src/functions.php
@@ -30,12 +30,12 @@ function map(callable $func = null): Standard
     return $pipeline->map($func);
 }
 
-function take(\Traversable $input = null): Standard
+function take(iterable $input = null): Standard
 {
     return new Standard($input);
 }
 
 function fromArray(array $input): Standard
 {
-    return take(new \ArrayIterator($input));
+    return new Standard($input);
 }
diff --git a/tests/FunctionsTest.php b/tests/FunctionsTest.php
@@ -65,6 +65,14 @@ public function testTakeFunction()
         $this->assertSame(6, $pipeline->reduce());
     }
 
+    /**
+     * @covers \Pipeline\take
+     */
+    public function testTakeArray()
+    {
+        $this->assertSame([1, 2, 3, 4, 5], take([1, 2, 3, 4, 5])->toArray());
+    }
+
     /**
      * @covers \Pipeline\fromArray
      */