Skip to content
This repository has been archived by the owner on May 21, 2021. It is now read-only.

Commit

Permalink
Update ValidationError
Browse files Browse the repository at this point in the history
  • Loading branch information
sanmai committed Oct 18, 2020
1 parent c850a0a commit 5d44788
Show file tree
Hide file tree
Showing 2 changed files with 59 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/Responses/Bad/BadRequestResponse/ValidationError.php
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,11 @@ final class ValidationError implements HasErrorCode

public function getErrorCode(): ?string
{
return $this->errorCode;
}

public function getMessage(): string
{
return \sprintf('%s->%s %s', $this->objectName, $this->field, $this->message);
}
}
57 changes: 57 additions & 0 deletions tests/Deserialization/ValidationErrorTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
<?php
/**
* This code is licensed under the MIT License.
*
* Copyright (c) 2018-2020 Alexey Kopytko <alexey@kopytko.com> and contributors
* Copyright (c) 2018 Appwilio (http://appwilio.com), greabock (https://github.com/greabock), JhaoDa (https://github.com/jhaoda)
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
* THE SOFTWARE.
*/

declare(strict_types=1);

namespace Tests\YDeliverySDK\Deserialization;

use YDeliverySDK\Responses\Bad\BadRequestResponse\ValidationError;

/**
* @covers \YDeliverySDK\Responses\PostalCodeResponse
* @covers \YDeliverySDK\Responses\Types\PostalCode
*/
class ValidationErrorTest extends TestCase
{
private const EXAMPLE_ERROR = '{
"objectName": "senderOrderDraft",
"field": "deliveryType",
"message": "must not be null",
"conditionCode": "NotNull",
"arguments": {},
"errorCode": "FIELD_NOT_VALID"
}';

public function test_it_deserializes()
{
/** @var $error ValidationError */
$error = $this->getSerializer()->deserialize(self::EXAMPLE_ERROR, ValidationError::class);

$this->assertSame('FIELD_NOT_VALID', $error->getErrorCode());
$this->assertSame('senderOrderDraft->deliveryType must not be null', $error->getMessage());
$this->assertSame('NotNull', $error->conditionCode);
}
}

0 comments on commit 5d44788

Please sign in to comment.