Fix misc errors

sanmai · Oct 18, 2020 · de47cce · de47cce
1 parent 752872e
commit de47cce
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 9 deletions.
diff --git a/src/Requests/Templates/OrderRequest/Recipient.php b/src/Requests/Templates/OrderRequest/Recipient.php
@@ -51,6 +51,7 @@ final class Recipient extends CommonRecipient implements ReadableRequestProperty
      */
     public function __construct(?Address $address = null)
     {
+        /** @phpstan-ignore-next-line */
         $this->address = $address ?? new Address();
     }
 }
diff --git a/src/Requests/Types/Address.php b/src/Requests/Types/Address.php
@@ -29,15 +29,15 @@
 namespace YDeliverySDK\Requests\Types;
 
 use CommonSDK\Concerns\PropertyWrite;
-use CommonSDK\Contracts\Property;
+use CommonSDK\Contracts\ReadableRequestProperty;
 use JMS\Serializer\Annotation as JMS;
 
 /**
  * @property-write string $location
  * @property-write int $geoId
  * @property-write int[] $pickupPointIds
  */
-final class Address implements Property
+final class Address implements ReadableRequestProperty
 {
     use PropertyWrite;
 

diff --git a/src/Requests/Types/Cost.php b/src/Requests/Types/Cost.php
@@ -29,7 +29,7 @@
 namespace YDeliverySDK\Requests\Types;
 
 use CommonSDK\Concerns\PropertyWrite;
-use CommonSDK\Contracts\Property;
+use CommonSDK\Contracts\ReadableRequestProperty;
 use JMS\Serializer\Annotation as JMS;
 
 /**
@@ -38,7 +38,7 @@
  * @property-write float $manualDeliveryForCustomer
  * @property-write bool $fullyPrepaid
  */
-final class Cost implements Property
+final class Cost implements ReadableRequestProperty
 {
     use PropertyWrite;
 

diff --git a/src/Requests/Types/Dimensions.php b/src/Requests/Types/Dimensions.php
@@ -29,7 +29,7 @@
 namespace YDeliverySDK\Requests\Types;
 
 use CommonSDK\Concerns\PropertyWrite;
-use CommonSDK\Contracts\Property;
+use CommonSDK\Contracts\ReadableRequestProperty;
 use JMS\Serializer\Annotation as JMS;
 
 /**
@@ -38,7 +38,7 @@
  * @property-write int $width
  * @property-write float $weight
  */
-final class Dimensions implements Property
+final class Dimensions implements ReadableRequestProperty
 {
     use PropertyWrite;
 

diff --git a/src/Requests/Types/Shipment.php b/src/Requests/Types/Shipment.php
@@ -29,7 +29,7 @@
 namespace YDeliverySDK\Requests\Types;
 
 use CommonSDK\Concerns\PropertyWrite;
-use CommonSDK\Contracts\Property;
+use CommonSDK\Contracts\ReadableRequestProperty;
 use DateTimeInterface;
 use JMS\Serializer\Annotation as JMS;
 
@@ -40,7 +40,7 @@
  * @property-write int $warehouseId
  * @property-write bool $includeNonDefault
  */
-final class Shipment implements Property
+final class Shipment implements ReadableRequestProperty
 {
     use PropertyWrite;
 

diff --git a/src/Responses/CreateOrderResponse.php b/src/Responses/CreateOrderResponse.php
@@ -48,6 +48,9 @@ final class CreateOrderResponse implements Response, ScalarValue
      */
     private $id;
 
+    /**
+     * @phan-suppress PhanAccessReadOnlyMagicProperty
+     */
     public static function withValue($value)
     {
         $response = new self();

diff --git a/tests/Deserialization/ValidationErrorTest.php b/tests/Deserialization/ValidationErrorTest.php
@@ -47,7 +47,7 @@ class ValidationErrorTest extends TestCase
 
     public function test_it_deserializes()
     {
-        /** @var $error ValidationError */
+        /** @var ValidationError $error  */
         $error = $this->getSerializer()->deserialize(self::EXAMPLE_ERROR, ValidationError::class);
 
         $this->assertSame('FIELD_NOT_VALID', $error->getErrorCode());