Skip object fields when empty

examples/110_CreateAndSubmitOrder.php

@@ -155,7 +155,6 @@
 $place = $request->addPlace($dimensions);
 // $place->externalId = '427';
 $item = $place->addItem();
-$item->dimensions->length = $length / 2;
 $item->externalId = '428';
 $item->name = 'HELP';
 $item->count = 2;

src/Common/Item.php

@@ -102,6 +102,7 @@ abstract class Item
 
     /**
      * @JMS\Type("YDeliverySDK\Common\Dimensions")
+     * @JMS\SkipWhenEmpty
      *
      * @var Dimensions
      */

src/Common/Place.php

@@ -53,6 +53,7 @@ abstract class Place
 
     /**
      * @JMS\Type("YDeliverySDK\Common\Dimensions")
+     * @JMS\SkipWhenEmpty
      *
      * @var Dimensions
      */

src/Common/Recipient.php

@@ -90,6 +90,7 @@ abstract class Recipient
 
     /**
      * @JMS\Type("YDeliverySDK\Common\Address")
+     * @JMS\SkipWhenEmpty
      *
      * @var Address
      */

src/Requests/Templates/OrderRequest.php

@@ -102,13 +102,15 @@ abstract class OrderRequest implements JsonRequest
 
     /**
      * @JMS\Type("YDeliverySDK\Requests\Templates\OrderRequest\Recipient")
+     * @JMS\SkipWhenEmpty
      *
      * @var OrderRequest\Recipient
      */
     protected $recipient;
 
     /**
      * @JMS\Type("YDeliverySDK\Requests\Templates\OrderRequest\Cost")
+     * @JMS\SkipWhenEmpty
      *
      * @var OrderRequest\Cost
      */
@@ -123,13 +125,15 @@ abstract class OrderRequest implements JsonRequest
 
     /**
      * @JMS\Type("YDeliverySDK\Common\DeliveryOption")
+     * @JMS\SkipWhenEmpty
      *
      * @var Common\DeliveryOption
      */
     protected $deliveryOption;
 
     /**
      * @JMS\Type("YDeliverySDK\Requests\Types\Shipment")
+     * @JMS\SkipWhenEmpty
      *
      * @var Shipment
      */

src/Requests/Templates/OrderRequest/Place.php

@@ -55,7 +55,7 @@ public function __construct(?Dimensions $dimensions = null, array $items = [])
 
     public function addItem(?Dimensions $dimensions = null): Item
     {
-        $item = new Item($dimensions ?? $this->dimensions);
+        $item = new Item($dimensions);
 
         $this->items[] = $item;
 

tests/Serialization/ItemTest.php

@@ -0,0 +1,54 @@
+<?php
+/**
+ * This code is licensed under the MIT License.
+ *
+ * Copyright (c) 2018-2020 Alexey Kopytko <alexey@kopytko.com> and contributors
+ * Copyright (c) 2018 Appwilio (http://appwilio.com), greabock (https://github.com/greabock), JhaoDa (https://github.com/jhaoda)
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ * THE SOFTWARE.
+ */
+
+declare(strict_types=1);
+
+namespace Tests\YDeliverySDK\Serialization;
+
+use YDeliverySDK\Requests\Templates\OrderRequest;
+
+/**
+ * @covers \YDeliverySDK\Requests\Templates\OrderRequest\Item
+ */
+final class ItemTest extends TestCase
+{
+    public function test_serialize_item_without_dimensions()
+    {
+        $item = new OrderRequest\Item();
+        $item->externalId = '123';
+
+        $this->assertSameAsJSON('{"externalId":"123"}', $item);
+    }
+
+    public function test_serialize_item_with_dimensions()
+    {
+        $item = new OrderRequest\Item();
+        $item->externalId = '123';
+        $item->dimensions->height = 100;
+
+        $this->assertSameAsJSON('{"externalId":"123","dimensions":{"height":100.0}}', $item);
+    }
+}