Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only download coveralls on CI #67

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Conversation

fhunleth
Copy link

This makes the coveralls check optional when normalling building. It
removes the following lines from being printed when compiling projects
that depend on it:

===> Fetching coveralls (from
{git,"https://github.com/markusn/coveralls-erl",
                     {ref,"57a190502cd2606d2b5cc142bd5cec1ec7c497b2"}})
===> Compiling coveralls
_build/default/plugins/coveralls/src/coveralls.erl:103: Warning:
random:uniform/1: the 'random' module is deprecated; use the 'rand'
module instead

It also bumps coveralls to use the version stored on hex since the
specified version seemed pretty old.

This makes the coveralls check optional when normalling building. It
removes the following lines from being printed when compiling projects
that depend on it:

```
===> Fetching coveralls (from
{git,"https://github.com/markusn/coveralls-erl",
                     {ref,"57a190502cd2606d2b5cc142bd5cec1ec7c497b2"}})
===> Compiling coveralls
_build/default/plugins/coveralls/src/coveralls.erl:103: Warning:
random:uniform/1: the 'random' module is deprecated; use the 'rand'
module instead

```

It also bumps coveralls to use the version stored on hex since the
specified version seemed pretty old.
@fhunleth
Copy link
Author

I am hoping this works on Travis, but it doesn't appear that Travis is running on the PR.

@fhunleth
Copy link
Author

It looks like Travis ran and that Coveralls also ran.

https://travis-ci.com/github/fhunleth/websocket_client/jobs/324985988

I'm not sure about the failure. Maybe the upload of the results to coveralls.io didn't work? At any rate, it seems to look the same as the errors that I get from Travis before this change.

@sanmiguel
Copy link
Owner

Not sure why it's returning 1 after that - it certainly looks like it ran successfully.
Tests have passed, cover report was successfully sent to coveralls.io - I'll merge this and figure out the failure another time.

Thank you for your help!

@sanmiguel sanmiguel merged commit 003c1b7 into sanmiguel:master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants