Support OTP 25 #73
Support OTP 25 #73
Conversation
|
On further observation, there's another nuance I need to deal with here. |
kelcecil
force-pushed
the
support-otp-25
branch
2 times, most recently
from
956f1c4
to
fc9c76b
Compare
|
I've made my adjustments and have the test suite passing. I think this is ready for consideration. |
|
Thank you, @kelcecil. This will help us keep moving forward :) |
|
Bumping this thread. This issue prevents our upgrade to OTP 25, and I'd love to get it merged to avoid managing our own fork. Let me know what I can do! |
|
Hi @kelcecil - thanks so much for this! I'll hopefully get a chance to check it out early next week, will let you know when I get to it. |
|
Looking forward to seeing this get merged in. Thanks for the work! |
|
Hey! Just checking in! Any fixes/changes/suggestions I need to apply for this to be merged? Happy to do what we need to move this forward! |
|
Hi, thanks so much for your patience. I've had to migrate to Github Actions for CI - would you mind rebasing and adding Thanks again for your patience, and for your contribution 👍 🙏 |
This updates websocket_client.start_link/5 to use uri_string.parse/1 instead of http_uri.parse/1. http_uri.parse/1 was removed in OTP 25 and is recommended to be repalced with uri_string.parse/1 which was introduced in OTP 21.
kelcecil
force-pushed
the
support-otp-25
branch
from
fc9c76b
to
12cc969
Compare
|
Absolutely! Added and waiting for approval to run! |
|
Following up again. Anything I can do to help move this forward? |
|
Love all the work on this! We have a branch pointing mix to the github branch but I'd love to call it stable use hex when this is merged. Any idea when that might be? |
|
Apologies for the delay. I've been trying to get this to run CI against all the OTP versions in the matrix via Github Actions, but I only ever get a few minutes at a time to look at it. I'll merge it as-is, which will trigger CI to run against |
|
🎉 |
This MR replaces
http_uri.parse/1(removed in OTP 25) withuri_string.parse/1(introduced in OTP 21). Additionally, this also expands the tested OTP versions in Travis CI to include OTP 23, 24, and 25 to ensure the use ofuri_string.parse/1doesn't break anything. Fixes #72.