Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix formaction dict class update #306

Merged
merged 2 commits into from Jul 20, 2018

Conversation

jmijn
Copy link
Contributor

@jmijn jmijn commented Jul 19, 2018

Description

The actions property of a View can contain a dictionary with a formaction. In Python, if you set a dictionary as an attribute to a class, and you update its value, the class dict is updated, not only the instance itself. Changed the code to no longer update the actions directly.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@coveralls
Copy link

coveralls commented Jul 19, 2018

Coverage Status

Coverage remained the same at 73.475% when pulling 80782db on bugfix/formaction_dict_class_update into 62a2bda on develop.

@mmarcos mmarcos merged commit ff3f3ff into develop Jul 20, 2018
@mmarcos mmarcos deleted the bugfix/formaction_dict_class_update branch February 25, 2019 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants