Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaissance 2K23 events... #14

Merged
merged 23 commits into from
Feb 12, 2023
Merged

Renaissance 2K23 events... #14

merged 23 commits into from
Feb 12, 2023

Conversation

Cyber-Infernox
Copy link
Contributor

Fixes #4
Implemented the Events component

Copy link
Collaborator

@verma-verse verma-verse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done a good job. However some changes are needed, look at the comments and make necessary changes....

client/src/components/Events/Events.css Outdated Show resolved Hide resolved
client/src/components/Events/Events.jsx Outdated Show resolved Hide resolved
client/src/components/Events/Events.jsx Outdated Show resolved Hide resolved
Converted few CSS to tailwind
Removed duplicate class in SVG
client/.eslintrc Outdated Show resolved Hide resolved
@sanskaromar sanskaromar requested review from vishwa511 and verma-verse and removed request for verma-verse February 11, 2023 17:58
@sanskaromar sanskaromar requested review from verma-verse and removed request for verma-verse February 11, 2023 17:59
@sanskaromar sanskaromar dismissed verma-verse’s stale review February 11, 2023 18:44

Requested changes implemented. (and Ashish is unavailable due to some personal reasons.)

@sanskaromar sanskaromar removed the request for review from verma-verse February 11, 2023 18:45
PriyavKaneria
PriyavKaneria previously approved these changes Feb 11, 2023
Copy link
Collaborator

@PriyavKaneria PriyavKaneria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
For bigger screen sizes if something like this can be done it would improve the overall look. Otherwise nice work

@NeerajChatterjee
Copy link
Collaborator

image For bigger screen sizes if something like this can be done it would improve the overall look. Otherwise nice work

Do this for sure as it would look good on Desktop.

@Cyber-Infernox
Copy link
Contributor Author

Cyber-Infernox commented Feb 12, 2023

image For bigger screen sizes if something like this can be done it would improve the overall look. Otherwise nice work

Done... 67bea01

@Cyber-Infernox
Copy link
Contributor Author

Cyber-Infernox commented Feb 12, 2023

image For bigger screen sizes if something like this can be done it would improve the overall look. Otherwise nice work

Do this for sure as it would look good on Desktop.

Done... 67bea01

Copy link
Collaborator

@vishwa511 vishwa511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make them a bit larger. Not just the position , size also matters a lot
you can also use span on first letters on each word and make them more large.
look at Priyav's hand written one and try to make like that
snap33

@Cyber-Infernox
Copy link
Contributor Author

Make them a bit larger. Not just the position , size also matters a lot you can also use span on first letters on each word and make them more large. look at Priyav's hand written one and try to make like that snap33

Done... fc4d95f

@sanskaromar sanskaromar merged commit e1a5361 into sanskaromar:frontend Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the Events Component
6 participants