TimelineItem::cancel() and composable Timelines #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip the intermediate connection object. Not all tests passing yet.
Motions don't generally need the control, so don't create it.
No longer needed since Motion and Output manage their relationship. A little more tightly coupled, but (I think) less confusing.
Working fine.
Removed some stuff, added new behaviors.
|
Need to update projects on Windows and confirm they still build and run before merging. |
Getting modified after freed crashes in samples (and probably the benchmarks test). Will need to try to trigger those in the main group of samples.
|
VS is revealing some issues with the unified cancel scheme (samples sometimes crash with modification after free; might be the new cancel, hopefully isn't the timeline::finish_fn). Will try to test for them and see if they occur at all on Clang. |
For windows...
Fixes crash on Windows. Previously, Output's destruction wouldn't fully disconnect Motion. Really, this should have crashed on the Mac, too. So thanks VS for highlighting the bug.
This reverts commit c416625.
|
Fixed cancel issue in 835d8d5 |
Exposes the consistent cancellation scheme.
sansumbrella
added a commit
that referenced
this pull request
Dec 2, 2014
TimelineItem::cancel() and composable Timelines
This was referenced Dec 2, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streamlines cancellation of TimelineItems.
MotionGroups are a facade around a Timeline, so you can simply compose Timelines.
Keep in mind that Timelines and unique_ptrs are move-only objects.