Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change title on README #4

Merged
merged 2 commits into from
Jun 1, 2020
Merged

change title on README #4

merged 2 commits into from
Jun 1, 2020

Conversation

sansyrox
Copy link
Owner

@sansyrox sansyrox commented Jun 1, 2020

Changed Title in the Readme

@github-learning-lab
Copy link
Contributor

Good pull requests help contributors understand the context. They have a body description detailing the suggested change.

Let's edit this pull request to add a body description.

⌨️ Activity: Fixing your pull request

  1. The first comment on your pull request will have the default text of No description provided. Click octicon-kebab-horizontal in the top right corner of the comment box to make an edit.
  2. Add a description of the changes you've made in the comment box. Feel free to add a description of what you’ve accomplished so far. As a reminder, you have:
    • Left reviews and line comments
    • Created a file and made a commit
    • Opened a pull request
  3. Click the green Update comment button at the bottom right of the comment box when done.

If you would like help troubleshooting, create a post on the GitHub Community board. You might also want to search for your issue to see if other people have resolved it in the past.


Watch below for my response

README.md Outdated Show resolved Hide resolved
Co-authored-by: github-learning-lab[bot] <37936606+github-learning-lab[bot]@users.noreply.github.com>
Copy link
Contributor

@github-learning-lab github-learning-lab bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step 7: Merge this pull request

Thanks for accepting my suggested change. Now that the pull request is finished, you should merge the change in and start playing your game!

⌨️ Activity: Merge pull request

  1. Click Merge pull request
  2. Click Confirm merge
  3. Delete the branch

@sansyrox sansyrox merged commit 265ed2c into master Jun 1, 2020
@github-learning-lab
Copy link
Contributor

Congratulations! 🎉

hulatocat

Nice work helping me with all these pull requests! As you continue working on GitHub, remember that high quality reviews improve your projects. If you are new to a repository, inquire about what review practices they have so you can hit the ground running.

@sansyrox sansyrox deleted the update-readme branch June 1, 2020 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants