Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groups / Teams #10

Closed
jlndk opened this issue Jul 2, 2016 · 7 comments
Closed

Groups / Teams #10

jlndk opened this issue Jul 2, 2016 · 7 comments

Comments

@jlndk
Copy link

jlndk commented Jul 2, 2016

Hi.

Ealier today I created an issue on the original entrust repo, regarding the possibility of adding groups to the package.

However i just noticed the concerns regarding the maintainer of the original repo, so I looked up forks and stumbled upon this. Even though I'm gonna make the pull request myself, I would very much prefer the code going into a maintained codebase.

(BTW I've done a lot of explanation of my problem on the original issue, so please check it out if you're unsure of what I mean by groups)

Personally I think many people would benifit for this feature, since It's very common for application to be based around groups (like slack).

@santigarcor
Copy link
Owner

@jlndk i think it would be useful so if you can make a PR it would be great.

@jacurtis
Copy link

Yes, I think this would be a great addition and would be used by many people.

@erikwestlund
Copy link

I think this would be awesome.

@santigarcor
Copy link
Owner

I'm going to start working in that during week.

@jlndk
Copy link
Author

jlndk commented Sep 7, 2016

My team found another way around this problem, but I'm glad someone else has started working on the feature :D

@santigarcor
Copy link
Owner

santigarcor commented Sep 11, 2016

@jlndk , @erikwestlund , @jacurtis I've done most of the groups implementation. Could you please try it in this branch. In packagist it's the dev-groups-implementation one.

These are the things you need to have in mind:

  • The detachRoles() when no param given, it'll only remove the roles that doesn't belongs to any group.
  • The attachRole, hasRole and can work like @jlndk described here.
  • The ability doesn't support groups yet.

I hope you can try that out, and if you find something please tell me so i can change it.

Cheers!

@santigarcor
Copy link
Owner

I just tagged a RC for the version with groups

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants