-
-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Namespace idea #9
Comments
Well i don't have any problem with that, but would be any problem with packagist? |
@santigarcor How do you mean? For all I know packagist isn't concerned at all with namespacing. It works eg. in https://github.com/briannesbitt/Carbon or https://github.com/kkszymanowski/traitor. |
Hmmm ok that's fine |
I'm in the process of refactoring Role and Permission generator commands and writing tests for them. Once I'm done, I will PR this namespace change. |
Love the idea |
How about using
Laratrust
as the vendor namespace instead ofSantigarcor\Laratrust
.For example
Santigarcor\Laratrust\LaratrustRole
would become simplyLaratrust\LaratrustRole
.It's easier to remember and
LaratrustFacade
due to an alias is used withoutSantigarcor
prefix so it would provide consistency.What do you think?
The text was updated successfully, but these errors were encountered: