Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace idea #9

Closed
KKSzymanowski opened this issue Jun 26, 2016 · 5 comments
Closed

Namespace idea #9

KKSzymanowski opened this issue Jun 26, 2016 · 5 comments

Comments

@KKSzymanowski
Copy link
Collaborator

How about using Laratrust as the vendor namespace instead of Santigarcor\Laratrust.
For example Santigarcor\Laratrust\LaratrustRole would become simply Laratrust\LaratrustRole.

It's easier to remember and LaratrustFacade due to an alias is used without Santigarcor prefix so it would provide consistency.

What do you think?

@santigarcor
Copy link
Owner

Well i don't have any problem with that, but would be any problem with packagist?

@KKSzymanowski
Copy link
Collaborator Author

@santigarcor How do you mean? For all I know packagist isn't concerned at all with namespacing.

It works eg. in https://github.com/briannesbitt/Carbon or https://github.com/kkszymanowski/traitor.

@santigarcor
Copy link
Owner

Hmmm ok that's fine

@KKSzymanowski
Copy link
Collaborator Author

KKSzymanowski commented Jun 28, 2016

I'm in the process of refactoring Role and Permission generator commands and writing tests for them. Once I'm done, I will PR this namespace change.

@Mathius17
Copy link
Contributor

Love the idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants