Fix for methods like is_compressed() not working.
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
causing exceptions with methods that try to return stat data from it, such as `is_compressed()`.
santigl
reviewed
Dec 28, 2021
Comment on lines
+243
to
+245
| # Why include sqlite_master if it doesn't hold usage data? | ||
| # -JL | ||
| #return [t['name'] for t in tables] + ['sqlite_master'] |
There was a problem hiding this comment.
Good catch! Thanks for opening this PR! I'm sorry for taking this long to review it, I somehow never received an email notification for it. :(
Just a nit:
Suggested change
| # Why include sqlite_master if it doesn't hold usage data? | |
| # -JL | |
| #return [t['name'] for t in tables] + ['sqlite_master'] | |
| # Do not include `sqlite_master` because it doesn't hold usage data |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anything that tries to work with usage data for the
sqlite_mastervirtual table would fail, as it returns None for quantity values.This pull requests corrects that by leaving
sqlite_masterout of the list of tables returned by the.tables()method.I also fixed an error where the value for the
is_compressed()method would never cache.