Change default to date #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valo
reviewed
Nov 12, 2018
| if isinstance(datetime_obj_or_str, datetime.datetime): | ||
| datetime_obj_or_str = datetime_obj_or_str.isoformat() | ||
|
|
||
| dt = iso8601.parse_date(datetime_obj_or_str) + datetime.timedelta(hours=23, minutes=59, seconds=59) |
There was a problem hiding this comment.
Why is the end of the day taken here?
There was a problem hiding this comment.
Seems to me that the end of the day is more appropriate here - otherwise it includes this day but without the full data for the day. You can check the examples here: #39
IvanIvanoff
approved these changes
Feb 11, 2019
valo
approved these changes
Feb 11, 2019
tspenov
force-pushed
the
change-default-to-date
branch
from
80d8bd1
to
928d03f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fix : #39