Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with agenda jobs #34

Closed
zlydenko opened this issue Sep 8, 2019 · 1 comment
Closed

Issue with agenda jobs #34

zlydenko opened this issue Sep 8, 2019 · 1 comment
Labels
good first issue Good for newcomers

Comments

@zlydenko
Copy link

zlydenko commented Sep 8, 2019

Hi, can you clear some things about agenda jobs? You're awaiting not async function

bulletproof-nodejs/src/jobs/emailSequence.ts

Line 11 in 9c1cd2a

await mailerServiceInstance.SendWelcomeEmail(email);

bulletproof-nodejs/src/services/mailer.ts

Line 10 in 9c1cd2a

public SendWelcomeEmail(email) {

@santiq santiq added the good first issue Good for newcomers label Sep 9, 2019
@santiq
Copy link
Owner

santiq commented Sep 11, 2019

Of course! Thanks for notice it :)

@JoseRFelix JoseRFelix mentioned this issue Oct 6, 2019
Merged
@santiq santiq closed this as completed in cfc5268 Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@santiq @zlydenko