Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20 add rename zipentry command #22

Merged
merged 37 commits into from
Feb 25, 2024
Merged

Conversation

santisq
Copy link
Owner

@santisq santisq commented Feb 25, 2024

Closes #20.
Fixes #21.

  • 02/25/2024
    • ZipEntryBase Type:
      • Renamed Property EntryName to Name.
      • Renamed Property EntryRelativePath to RelativePath.
      • Renamed Property EntryType to Type.
      • Renamed Method RemoveEntry() to Remove().
      • Added Property CompressionRatio.
    • ZipEntryFile Type:
      • Added Property Extension.
      • Added Property BaseName.
    • ZipEntryDirectory Type:
      • .Name Property now reflects the directory entries name instead of an empty string.
    • Added command Rename-ZipEntry.
    • NormalizePath Method:
      • Moved from [PSCompression.ZipEntryExtensions]::NormalizePath to [PSCompression.Extensions.PathExtensions]::NormalizePath.
    • Get-ZipEntry command:
      • Renamed Parameter -EntryType to -Type.

@santisq santisq added bug Something isn't working documentation Improvements or additions to documentation labels Feb 25, 2024
@santisq santisq self-assigned this Feb 25, 2024
@santisq santisq linked an issue Feb 25, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 25, 2024

Codecov Report

Attention: Patch coverage is 79.95825% with 96 lines in your changes are missing coverage. Please review.

Project coverage is 83.09%. Comparing base (e013d5a) to head (482b001).

Files Patch % Lines
src/PSCompression/Dbg/Nullable.cs 0.00% 23 Missing ⚠️
...rc/PSCompression/Commands/RenameZipEntryCommand.cs 73.75% 18 Missing and 3 partials ⚠️
src/PSCompression/Extensions/ZipEntryExtensions.cs 77.77% 10 Missing and 2 partials ⚠️
src/PSCompression/Commands/NewZipEntryCommand.cs 52.63% 8 Missing and 1 partial ⚠️
src/PSCompression/Exceptions/ExceptionHelpers.cs 82.05% 6 Missing and 1 partial ⚠️
...Compression/Commands/CompressGzipArchiveCommand.cs 50.00% 2 Missing and 1 partial ⚠️
...SCompression/Commands/CompressZipArchiveCommand.cs 62.50% 3 Missing ⚠️
...SCompression/Commands/SetZipEntryContentCommand.cs 81.25% 3 Missing ⚠️
src/PSCompression/ZipEntryCache.cs 90.00% 2 Missing and 1 partial ⚠️
src/PSCompression/ZipEntryFile.cs 83.33% 2 Missing and 1 partial ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   82.98%   83.09%   +0.10%     
==========================================
  Files          27       37      +10     
  Lines        1346     1656     +310     
  Branches      174      200      +26     
==========================================
+ Hits         1117     1376     +259     
- Misses        187      233      +46     
- Partials       42       47       +5     
Flag Coverage Δ
PS_5.1 82.24% <79.95%> (+0.29%) ⬆️
PS_7_Windows 79.64% <79.74%> (+0.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@santisq santisq merged commit 62f4e7e into main Feb 25, 2024
6 of 7 checks passed
@santisq santisq deleted the 20-add-rename-zipentry-command branch February 25, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get-ZipEntry - Object Ref Not Set To An Instance Of Obj Add Rename-ZipEntry command
1 participant