Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check headers regardless of case #41

Merged
merged 1 commit into from
May 5, 2024
Merged

Check headers regardless of case #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions shcheck/shcheck.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,19 +317,19 @@ def main():
# Taking care of special headers that could have bad values

# X-XSS-Protection Should be enabled
if safeh == 'X-XSS-Protection' and headers.get(lsafeh) == '0':
if safeh == 'X-XSS-Protection'.lower() and headers.get(lsafeh) == '0':
log("[*] Header {} is present! (Value: {})".format(
colorize(safeh, 'ok'),
colorize(headers.get(lsafeh), 'warning')))

# unsafe-url policy is more insecure compared to the default/unset value
elif safeh == 'Referrer-Policy' and headers.get(lsafeh) == 'unsafe-url':
elif safeh == 'Referrer-Policy'.lower() and headers.get(lsafeh) == 'unsafe-url':
log("[!] Insecure header {} is set! (Value: {})".format(
colorize(safeh, 'warning'),
colorize(headers.get(lsafeh), 'error')))

# check for max-age=0 in HSTS
elif safeh == 'Strict-Transport-Security' and "max-age=0" in headers.get(lsafeh):
elif safeh == 'Strict-Transport-Security'.lower() and "max-age=0" in headers.get(lsafeh):
log("[!] Insecure header {} is set! (Value: {})".format(
colorize(safeh, 'warning'),
colorize(headers.get(lsafeh), 'error')))
Expand All @@ -343,7 +343,7 @@ def main():
unsafe += 1
json_results["missing"].append(safeh)
# HSTS works obviously only on HTTPS
if safeh == 'Strict-Transport-Security' and not is_https(rUrl):
if safeh == 'Strict-Transport-Security'.lower() and not is_https(rUrl):
unsafe -= 1
json_results["missing"].remove(safeh)
continue
Expand Down