Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct filename of example #15

Open
tschmidtb51 opened this issue Feb 23, 2023 · 1 comment
Open

Correct filename of example #15

tschmidtb51 opened this issue Feb 23, 2023 · 1 comment

Comments

@tschmidtb51
Copy link
Contributor

tschmidtb51 commented Feb 23, 2023

The example has an invalid filename according to section 5.1. Either, we change the /document/tracking/id or we change the filename. Given that we might want to add multiple files to enhance the coverage, I guess it makes sense to update the /document/tracking/id, e.g. to example 01 valid and the filename to example_01_valid.json.

@santosomar, @sthagen: Thoughts?

@sthagen
Copy link
Collaborator

sthagen commented Feb 23, 2023

The example has an invalid filename according to section 5.1. Either, we change the /document/tracking/id or we change the filename. Given that we might want to add multiple files to enhance the coverage, I guess it makes sense to update the /document/tracking/id, e.g. to example 01 valid and the filename to example_01_valid.json.
[...]

I like the latter (update the /document/tracking/id, e.g. to example 01 valid and the filename to example_01_valid.json)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants