fix: remove hard code image in hero component

sanyuan0704 · Sep 18, 2022 · 2bd354f · 2bd354f
1 parent 647cc47
commit 2bd354f
Show file tree

Hide file tree

Showing 8 changed files with 22 additions and 13 deletions.
diff --git a/docs/.island/config.ts b/docs/.island/config.ts
@@ -2,8 +2,8 @@ import { defineConfig } from '../../dist';
 
 export default defineConfig({
   lang: 'en-US',
-  title: '666',
-  icon: '/icon.png',
+  title: 'Island.js',
+  icon: '/island.png',
   themeConfig: {
     socialLinks: [
       {
@@ -37,7 +37,7 @@ function getTutorialSidebar() {
       ]
     },
     {
-      text: 'Concepts',
+      text: 'Architecture',
       items: [
         { text: 'SPA vs MPA', link: '/guide/spa-vs-mpa' },
         { text: 'Islands Architecture', link: '/guide/islands-arch' }

diff --git a/docs/index.md b/docs/index.md
@@ -5,6 +5,9 @@ hero:
   name: Island
   text: Vite & Islands Arch Static Site Generator
   tagline: Simple, powerful, and performant. Meet the modern SSG framework you've always wanted.
+  image:
+    src: /island.png
+    alt: Island
   actions:
     - theme: brand
       text: Get Started

diff --git a/docs/public/icon.png b/docs/public/icon.png
diff --git a/...me-default/components/HomeHero/island.png → docs/public/island.png b/...me-default/components/HomeHero/island.png → docs/public/island.png
diff --git a/src/node/plugin-island/config.ts b/src/node/plugin-island/config.ts
@@ -34,7 +34,6 @@ export function pluginConfig(
     },
     config(c) {
       return {
-        root: PACKAGE_ROOT_PATH,
         optimizeDeps: {
           include: [
             'react',

diff --git a/src/node/plugin.ts b/src/node/plugin.ts
@@ -7,7 +7,7 @@ import { SiteConfig } from '../shared/types';
 import { pluginMdx } from './plugin-mdx';
 import babelPluginIsland from './babel-plugin-island';
 import { ISLAND_JSX_RUNTIME_PATH } from './constants/index';
-import pluginInspect from 'vite-plugin-inspect';
+// import pluginInspect from 'vite-plugin-inspect';
 
 export async function createIslandPlugins(
   config: SiteConfig,

diff --git a/src/shared/types/index.ts b/src/shared/types/index.ts
@@ -112,6 +112,10 @@ export interface Hero {
   name: string;
   text: string;
   tagline: string;
+  image?: {
+    src: string;
+    alt: string;
+  };
   actions: {
     text: string;
     link: string;

diff --git a/src/theme-default/components/HomeHero/index.tsx b/src/theme-default/components/HomeHero/index.tsx
@@ -1,21 +1,22 @@
 import { usePageData } from 'island/client';
 import { Button } from '../Button';
 import styles from './index.module.scss';
-import logo from './island.png';
 import { normalizeHref } from '../../logic/index';
 
 const DEFAULT_HERO = {
   name: 'Island',
   text: 'Island ssg',
   tagline: 'Island ssg',
-  actions: []
+  actions: [],
+  image: undefined
 };
 
 export function HomeHero() {
   const { hero = DEFAULT_HERO } = usePageData();
+  const hasImage = hero.image !== undefined;
 
   return (
-    <div className={`${styles.hero} ${styles.hasImage}`}>
+    <div className={`${styles.hero} ${hasImage ? styles.hasImage : ''}`}>
       <div className={styles.container}>
         <div className={styles.main}>
           <h1 className={styles.name}>
@@ -36,12 +37,14 @@ export function HomeHero() {
             ))}
           </div>
         </div>
-        <div className={styles.image}>
-          <div className={styles.imageContainer}>
-            <div className={styles.imageBg} />
-            <img src={logo} alt="" />
+        {hasImage ? (
+          <div className={styles.image}>
+            <div className={styles.imageContainer}>
+              <div className={styles.imageBg} />
+              <img src={hero.image?.src} alt={hero.image?.alt} />
+            </div>
           </div>
-        </div>
+        ) : null}
       </div>
     </div>
   );