feat: remove throttle for keydown handler (#132)

* feat: remove throttle for keydown handler * Create tough-cooks-remain.md Co-authored-by: yangxingyuan <39261479+sanyuan0704@users.noreply.github.com>
sanyuan0704 · Oct 31, 2022 · 5c1be07 · 5c1be07 · vercel · Oct 31, 2022
1 parent ba87fe4
commit 5c1be07
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/.changeset/tough-cooks-remain.md b/.changeset/tough-cooks-remain.md
@@ -0,0 +1,7 @@
+---
+"@islandjs/plugin-search": patch
+"@islandjs/plugin-backtop": patch
+"islandjs": patch
+---
+
+feat: remove throttle for keydown handler
diff --git a/packages/plugin-search/src/component/index.tsx b/packages/plugin-search/src/component/index.tsx
@@ -3,7 +3,6 @@ import { ChangeEvent, useCallback, useEffect, useRef, useState } from 'react';
 import type { MatchResultItem, PageSearcher } from '../logic/search';
 import SearchSvg from '../assets/search.svg';
 import LoadingSvg from '../assets/loading.svg';
-import { throttle } from 'lodash-es';
 import { SuggestionContent } from './Suggestion';
 
 const KEY_CODE = {
@@ -59,7 +58,7 @@ export function Search(
   );
 
   useEffect(() => {
-    const onKeyDown = throttle((e: KeyboardEvent) => {
+    const onKeyDown = (e: KeyboardEvent) => {
       switch (e.code) {
         case KEY_CODE.SEARCH:
           if ((e.ctrlKey || e.metaKey) && searchInputRef.current) {
@@ -95,7 +94,7 @@ export function Search(
         default:
           break;
       }
-    }, 200);
+    };
     document.addEventListener('keydown', onKeyDown);
     return () => {
       document.removeEventListener('keydown', onKeyDown);