feat: add normalize link remark plugin

sanyuan0704 · Sep 24, 2022 · a5151f4 · a5151f4
1 parent 3f9681d
commit a5151f4
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 20 deletions.
diff --git a/src/node/plugin-island/config.ts b/src/node/plugin-island/config.ts
@@ -116,15 +116,15 @@ export function pluginConfig(
       }
     },
     configureServer(server) {
-      return async () => {
-        // Serve public dir
-        // Cause by the pre-bundle problem, we have to set the island package as the root dir
-        // So we need to serve the public dir in user's root dir manually
-        const publicDir = path.join(config.root, PUBLIC_DIR);
-        if (await fs.pathExists(publicDir)) {
-          server.middlewares.use(sirv(publicDir));
-        }
-      };
+      // Serve public dir
+      // Cause by the pre-bundle problem, we have to set the island package as the root dir
+      // So we need to serve the public dir in user's root dir manually
+
+      const publicDir = path.join(config.root, PUBLIC_DIR);
+      if (fs.pathExistsSync(publicDir)) {
+        server.middlewares.use(sirv(publicDir));
+      }
+      server.middlewares.use(sirv(config.root));
     }
   };
 }
diff --git a/src/node/plugin-mdx/pluginMdxRollup.ts b/src/node/plugin-mdx/pluginMdxRollup.ts
@@ -27,7 +27,10 @@ export async function pluginMdxRollup(
       remarkPluginFrontMatter,
       [remarkPluginMDXFrontMatter, { name: 'meta' }],
       remarkPluginToc,
-      [remarkPluginNormalizeLink, { base: config.base }]
+      [
+        remarkPluginNormalizeLink,
+        { base: config.base || '/', enableSpa: config.enableSpa }
+      ]
     ],
     rehypePlugins: [
       rehypePluginSlug,

diff --git a/src/node/plugin-mdx/remarkPlugins/link.ts b/src/node/plugin-mdx/remarkPlugins/link.ts
@@ -2,34 +2,36 @@ import type { Plugin } from 'unified';
 import { visit } from 'unist-util-visit';
 import path from 'path';
 import { isProduction } from '../../../node/constants';
+import { parseUrl } from '../../../node/utils';
 
 /**
  * Remark plugin to normalize a link href
  */
-export const remarkPluginNormalizeLink: Plugin<[{ base: string }]> =
-  ({ base }) =>
+export const remarkPluginNormalizeLink: Plugin<
+  [{ base: string; enableSpa: boolean }]
+> =
+  ({ base, enableSpa }) =>
   (tree) => {
     visit(
       tree,
       // eslint-disable-next-line @typescript-eslint/no-explicit-any
-      (node: any) => node.type === 'a',
+      (node: any) => node.type === 'link',
       // eslint-disable-next-line @typescript-eslint/no-explicit-any
       (node: any) => {
-        let url: string = node.url;
+        // eslint-disable-next-line prefer-const
+        let { url, hash } = parseUrl(node.url);
         const extname = path.extname(url);
 
         if (extname === '.md' || extname === '.mdx') {
           url = url.replace(extname, '');
         }
 
-        if (
-          isProduction() &&
-          !import.meta.env.ENABLE_SPA &&
-          extname !== '.html'
-        ) {
+        if (isProduction() && !enableSpa && extname !== '.html') {
           url += '.html';
         }
-
+        if (hash) {
+          url += `#${hash}`;
+        }
         node.url = path.join(base, url);
       }
     );